I'd like to see AbstractSource deprecated. It for example requires the use of super when overriding methods such as start(), and stop().  This is a a poor practice and I think it's better to provide explicit hooks which is what BasicSourceSemantics does.

Yeah I think this was a copy paste error. I like expected = as well except in the case where a prerequisite method could throw the same exception. That is not the case here.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8558/#review14408
-----------------------------------------------------------
On Dec. 12, 2012, 9:17 p.m., Brock Noland wrote: