Aishwarya,
Why is bullet point (2) formatted as "strike through"? If you intend to
replace it with bullet point (3), just remove it completely. The KIP
should reflect the actual proposal. Maybe move it to "Rejected
Alternative" section?
For (3c), it should also say, if `Materialize` specifies a queryable
store name. If there is no store name provided, either (a) or (b) applies.
Overall LGTM. Feel free to start a vote.
-Matthias
On 10/1/19 7:48 AM, aishwarya kumar wrote:
> Thank you all for the feedback, I will keep this thread open for discussion
> for a couple of more days and then start with the voting process.
>
> Best regards,
> Aishwarya
>
> On Fri, Sep 27, 2019, 12:37 PM John Roesler <[EMAIL PROTECTED]> wrote:
>
>> Looks good to me! I have no further comments.
>>
>> Thanks again for the KIP, Aishwarya!
>> -John
>>
>> On Fri, Sep 27, 2019 at 10:11 AM aishwarya kumar <[EMAIL PROTECTED]>
>> wrote:
>>>
>>> Hello John,
>>>
>>> Thank you for pointing this out to me, to maintain consistency across
>> API's
>>> it does make sense to allow users to define custom names for
>>> their processors.
>>>
>>> I've made the change in the KIP:
>>>
>>
https://cwiki.apache.org/confluence/display/KAFKA/KIP-523%3A+Add+KStream%23toTable+to+the+Streams+DSL>>>
>>> Best,
>>> Aishwarya
>>>
>>> On Tue, Sep 24, 2019 at 11:54 AM John Roesler <[EMAIL PROTECTED]> wrote:
>>>
>>>> Hey Aishwarya,
>>>>
>>>> Thanks for the KIP! It looks good to me, although in a post-KIP-307
>>>> world, we also need a "Named" parameter (to give the processor node a
>>>> name, as opposed to the store itself).
>>>>
>>>> This would result in a total of four overloads:
>>>> 1. no args
>>>> 2. Named
>>>> 3. Materialized
>>>> 4. Materialized, Named
>>>>
>>>> I'd like to propose a re-design of the DSL in the future to clean this
>>>> up, but for now, this is the pattern we have to follow.
>>>>
>>>> Thoughts?
>>>>
>>>> Thanks,
>>>> -John
>>>>
>>>> On Tue, Sep 24, 2019 at 9:54 AM aishwarya kumar <[EMAIL PROTECTED]>
>>>> wrote:
>>>>>
>>>>> Thank you for the suggestion Matthais, i've made the necessary
>> changes in
>>>>> the KIP.
>>>>>
>>>>> Keeping this thread open for further input.
>>>>> KIP link:
>>>>>
>>>>
>>
https://cwiki.apache.org/confluence/display/KAFKA/KIP-523%3A+Add+KStream%23toTable+to+the+Streams+DSL>>>>>
>>>>> Best,
>>>>> Aishwarya
>>>>>
>>>>> On Thu, Sep 19, 2019 at 10:50 AM aishwarya kumar <[EMAIL PROTECTED]
>>>
>>>> wrote:
>>>>>
>>>>>> Thanks Matthias,
>>>>>>
>>>>>> That does make sense, let me update the KIP to reflect the
>>>> Materialization
>>>>>> scenario.
>>>>>>
>>>>>> Best,
>>>>>> Aishwarya
>>>>>>
>>>>>> On Tue, Sep 17, 2019, 2:49 PM Matthias J. Sax <
>> [EMAIL PROTECTED]>
>>>>>> wrote:
>>>>>>
>>>>>>> Aishwarya,
>>>>>>>
>>>>>>> thanks for the KIP. Overall, I think it makes sense to allow
>>>> converting
>>>>>>> a KStream into a KTable.
>>>>>>>
>>>>>>> From the KIP:
>>>>>>>
>>>>>>>> materializing these KTables should only be allowed if the
>> overloaded
>>>>>>> function with Materialized is used (and if optimization is turned
>> on
>>>> it may
>>>>>>> still be only logically materialized if the queryable name is not
>>>> set).
>>>>>>>
>>>>>>> Can you elaborate? I think the behavior we want should align with
>> the
>>>>>>> behavior of `StreamsBuilder#table()`.
>>>>>>>
>>>>>>> From my understanding (correct me if I am wrong) it should be:
>>>>>>>
>>>>>>> (1) If optimization is turned off, the KTable will always be
>>>>>>> materialized, independent which method is used. The KTable will
>> not be
>>>>>>> queryable though.
>>>>>>>
>>>>>>> (2) If optimization is turned on and if `toTable()` is used, the
>>>> KTable
>>>>>>> may or may not be materialized. For this case, even if the KTable
>> is
>>>>>>> materialized, the store would not be queryable.
>>>>>>>
>>>>>>> (3) If `toTable(Materialized)` is use and a `storeName` or
>>>>>>> `StoreSupplier` is specified, the store will always be
>> materialized
>>>> and
>>>>>>> also be queryable. Otherwise, case (1) or (2) applies.
Comment: GPGTools -
https://gpgtools.orgiQIzBAEBCgAdFiEE8osu2CcCCF5douGQu8PBaGu5w1EFAl2btvEACgkQu8PBaGu5
w1HgvhAApt8575STbscchIMmsMw+AGSPpPMR20FNwYIIoe1/ssm9wOkRwhr7IOFV
aK81TZQcqUV1Mmyftjin7KPtHvJrG4+mZfGyyDOhtZrybB2fz4u1Vbkg6bZ6GeIt
rupZmULPy2LHP7D5t0VJrbBbNs/9rhlPDl9gIuu0DHcSID6syE1T3zc/xC21Nd8G
vv/dGlCv81AJmZZgMppk4FSk7znekC+/JW2K7UHIzJsyhvr1JopIVXJhiLDD1ODa
Xm2GGL9B2oYK1hg+ZlF+Wnp8UXEXWn/nmd5/uGbz2mEgrKnJj/+jHZ4LF4D5wVMv
SrgYirbYUex5igPcbdqT+3avhMFFIMOKm01+aZ4fC0kDaZHfzwO8R2A3BDTpXwmT
ZK3YEDJSOe7bDCJIixcq/Qy60JkR50Z6jeqRQ22tuygF+uF41qbDql/QRBokhLzG
jhj0B9Z3fyQwH78exMEpyUow4s4O+9PCVCDKXqhGS+nL7pqzDS4TQe3GP/wAkBTv
uiaVOrZmSf6zTp7SDyxBDqSwg9Vp4H6efCZZ9Xz8zOvN31b/wSOvgs0/LNT6O/vy
g3N7xaOhz2hsFsAXK9cJA7f/4xDihU9P0vnguJxr8LwoF8gVoDLSdTdcKi2Ze9Z/
2MV2y+1EMVx+bwDQ9+NcXDV/5y4DbA6V3aEygTZTBZNvZrUIsoM=
=OvAo