Subject: [DISCUSS] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions


Well, that's exactly the point. The serializer should not be altered
IMHO because this would have impact on other components. Also, for
applications that use KafkaProducer directly, they can catch any
serialization exception and react to it. Hence, I don't don't see a
reason to change the serializer interface.

Instead, it seems better to solve this issue in Streams by allowing to
skip over a record for this case.

Some more comments on the KIP:

 - the proposed method accepts a `ProducerRecord` -- it might be good to
explain why this cannot be done in a type safe way (ie, missing generics)

 - `AlwaysProductionExceptionHandler` ->
`AlwaysContinueProductionExceptionHandler`

 - `DefaultProductionExceptionHandler` is not mentioned

 - Why do you distinguish between `ClassCastException` and "any other
unchecked exception? Both second case seems to include the first one?

-Matthias

On 12/6/18 8:35 AM, Matt Farmer wrote:
Comment: GPGTools - https://gpgtools.org

iQIzBAEBCgAdFiEESn/iOv2tmCkcP0KLVp2sL37kObwFAlwJWOMACgkQVp2sL37k
ObxZvRAAhAwoFoOt8XpZgOLK3QyGiaIvXv5ZLLptymqC15aEMZtIx0kBy7XrN7ht
XpMRox7joMkzB4/KV/ksqUv5NqUJfWv7P209+gJIsqzHHyCuZPSNVxY3LgDN9T5w
ADWuT0zBOn2CmVHZtVwaBhCYfH4+13NNPi3pJfIaIDjvtOW4dWCU9RzHWhkQMTTR
PZRC1WrFOQDQDgbFPa0CHEV2fZ57o5ZMzuAOvlyLq7qG1zW5EFfEk2B0t4UbsdK8
Oi5nzSNWAQDRp+gGvJsd+S3cBwM3YTWiI41U/4kk53dVidPDvG3M5LIJSgx0YxTa
okQ2uzdt/9k+uwP/pVgzd4cXJzRghNBAe6r7JF2junA0OeTHvKa0lwp/wu6wS3oP
y59um4ha4dn1JibC8fQNGcQbZ/zBQ5+0JFnNsyEohYW8XO5NPOgpdZF7Pk8W6DBQ
0ifPsqRu0nPvdwF+PkUQiPJO9BU/K4WE+HzGUh+e0cSD/4dpT+QvN5U4zq9Pt5ys
eAA4LDJU/0CeAZEMHyqsMzeu9M9o5S6L42FWjcqz1tzSBOGeX+Fte0Sn3mdFZJxY
G8juMszUQ8vyZiNMWEoqX7SKglZGOjD3QMWoLGs4lTHYI/RFdzG4bL8/8gg8go05
VTcknVteyDwZ1nALscyy8Yb2BQqmyELwj6rVmUtIKuDIvA3Fyd0=
=s8SA
-----END PGP SIGNATURE-----