Subject: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))


On 2019/10/16 18:10, Johan Corveleyn wrote:

It seems the change addressing for it on swig-py3 branch is a part of
r1822485, the hunks attached.
--
Yasuhito FUTATSUKI <[EMAIL PROTECTED]> Index: gen_win_dependencies.py
===================================================================
--- gen_win_dependencies.py (revision 1822484)
+++ gen_win_dependencies.py (revision 1822485)
@@ -1069,7 +1122,7 @@
     try:
       outfp = subprocess.Popen([os.path.join(jdk_path, 'bin', 'javah.exe'),
                                '-version'], stdout=subprocess.PIPE).stdout
-      line = outfp.read()
+      line = outfp.read().decode('utf8')
       if line:
         vermatch = re.search(r'"(([0-9]+(\.[0-9]+)+)(_[._0-9]+)?)"', line, re.M)
       else:
@@ -1127,7 +1180,7 @@
     try:
       fp = subprocess.Popen([self.swig_exe, '-version'],
                             stdout=subprocess.PIPE).stdout
-      txt = fp.read()
+      txt = fp.read().decode('utf8')
       if txt:
         vermatch = re.search(r'^SWIG\ Version\ (\d+)\.(\d+)\.(\d+)', txt, re.M)
       else:
@@ -1155,7 +1208,7 @@
     try:
       fp = subprocess.Popen([self.swig_exe, '-swiglib'],
                             stdout=subprocess.PIPE).stdout
-      lib_dir = fp.readline().strip()
+      lib_dir = fp.readline().decode('utf8').strip()
       fp.close()
     except OSError:
       lib_dir = None